Generate message IDs with CSPRNG instead of Date.now+random#5
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vulnerability
newId()inplugin/src/wire.tsgenerated message IDs fromDate.now()concatenated withMath.floor(Math.random() * 36**12). Both inputs are predictable:Date.now()is observable/guessable to the millisecond.Math.random()is not a CSPRNG — its output is predictable and can collide.Message IDs are used to correlate request/response envelopes and to assemble multi-part (chunked) messages sharing the same
id. Predictable or colliding IDs allow an attacker to guess in-flight IDs (enabling spoofed replies / chunk injection) and risk accidental collisions that cross-contaminate reassembly buffers.Fix
Replace the ad-hoc generator with
crypto.randomUUID()(Node Web Crypto-backed CSPRNG), which is unique and unpredictable.newId()keeps the same synchronous() => stringsignature, so all call sites are unaffected.Verification
npm run build(tsc) — clean, no type errors.npm test(vitest) — 230/230 pass, including thenewIduniqueness test.